NI-CAN: Add reset method and remove flush_tx_buffer method#364
Merged
christiansandberg merged 2 commits intohardbyte:developfrom Jul 17, 2018
Merged
NI-CAN: Add reset method and remove flush_tx_buffer method#364christiansandberg merged 2 commits intohardbyte:developfrom
christiansandberg merged 2 commits intohardbyte:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #364 +/- ##
========================================
Coverage 58.56% 58.56%
========================================
Files 54 54
Lines 4219 4219
========================================
Hits 2471 2471
Misses 1748 1748
Continue to review full report at Codecov.
|
felixdivo
approved these changes
Jul 17, 2018
Collaborator
felixdivo
left a comment
felixdivo
left a comment
There was a problem hiding this comment.
The docs could also state what the consequences of resetting are in the case.
Collaborator
|
Top! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually renames the old
flush_tx_bufferwhich did a reset which is not really the same thing.