Adding neoVI support for receive_own_messages#434
Merged
felixdivo merged 4 commits intohardbyte:developfrom Oct 5, 2018
pierreluctg:receive_own_messages
Merged
Adding neoVI support for receive_own_messages#434felixdivo merged 4 commits intohardbyte:developfrom pierreluctg:receive_own_messages
felixdivo merged 4 commits intohardbyte:developfrom
pierreluctg:receive_own_messages
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #434 +/- ##
===========================================
- Coverage 62.47% 62.42% -0.06%
===========================================
Files 55 55
Lines 4661 4665 +4
===========================================
Hits 2912 2912
- Misses 1749 1753 +4 |
felixdivo
approved these changes
Sep 28, 2018
Collaborator
felixdivo
left a comment
felixdivo
left a comment
There was a problem hiding this comment.
Did you test that this works? If yes, I think we can merge this as-is.
Collaborator
Author
|
@felixdivo yes, this was tested with ValueCAN3, ValueCAN4-2 and neoVI FIRE2 with the latest driver. |
Collaborator
|
Sounds good! @hardbyte I don't want to mess with the release, so I would wait until you merged 3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.