VectorBus - add methods to handle non message events#708
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #708 +/- ##
===========================================
+ Coverage 68.44% 68.57% +0.12%
===========================================
Files 69 69
Lines 6218 6227 +9
===========================================
+ Hits 4256 4270 +14
+ Misses 1962 1957 -5 |
christiansandberg
left a comment
There was a problem hiding this comment.
Since the methods are to be used outside of the library they should not be internal, i.e. remove the underscore from the beginning of the names.
|
Hello Christian, |
|
If they start with an underscore there is no guarantee that they will be called in future versions, which might break applications relying on their existence. If they are public, they need to be treated according to semantic versioning meaning backwards incompatible changes may only be introduced in a new major version. |
Add methods to handle vector driver events that are not caused by incoming messages. Can be implemented by subclassing.
I do not know if the docstrings are okay.
sphinx-build doc/ doc/_buildcauses an error atreading sources... [ 16%] bus:AttributeError: 'property' object has no attribute 'expandtabs'