Skip to content

Add support for changing the loopback flag#960

Merged
felixdivo merged 7 commits intohardbyte:developfrom
jjguti:feature/add-loopback-flag
Apr 14, 2021
Merged

Add support for changing the loopback flag#960
felixdivo merged 7 commits intohardbyte:developfrom
jjguti:feature/add-loopback-flag

Conversation

@jjguti
Copy link
Contributor

@jjguti jjguti commented Dec 18, 2020

Small PR to allow the local loopback to be disabled/enabled on a socketcan interface.

@mergify mergify bot requested a review from hardbyte December 18, 2020 13:30
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #960 (51edc8a) into develop (7ddea9e) will decrease coverage by 0.51%.
The diff coverage is 60.00%.

@@             Coverage Diff             @@
##           develop     #960      +/-   ##
===========================================
- Coverage    70.78%   70.27%   -0.52%     
===========================================
  Files           75       76       +1     
  Lines         7267     7401     +134     
===========================================
+ Hits          5144     5201      +57     
- Misses        2123     2200      +77     

@felixdivo
Copy link
Collaborator

@jjguti This looks like a neat addition. But I think we should add a test to make sure it correctly loops back and only does so if the flag is set. Could You add that? Then, this can be merged.

@jjguti
Copy link
Contributor Author

jjguti commented Apr 14, 2021

@felixdivo Hi, I have now added a test for the local_loopback flag, please tell me if it's good enough for a merge or if something else should be added.

@felixdivo
Copy link
Collaborator

Thanks for your quick reply! And sorry for the long pause, there is recently quite a backlog of issues/PRs.

I think that the test is already nearly complete, but we should add a few lines, see my comments below.

Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@felixdivo
Copy link
Collaborator

Nice @jjguti!

@felixdivo felixdivo merged commit bea8c7c into hardbyte:develop Apr 14, 2021
@jjguti jjguti deleted the feature/add-loopback-flag branch April 14, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants