Add support for changing the loopback flag#960
Merged
felixdivo merged 7 commits intohardbyte:developfrom Apr 14, 2021
jjguti:feature/add-loopback-flag
Merged
Add support for changing the loopback flag#960felixdivo merged 7 commits intohardbyte:developfrom jjguti:feature/add-loopback-flag
felixdivo merged 7 commits intohardbyte:developfrom
jjguti:feature/add-loopback-flag
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #960 +/- ##
===========================================
- Coverage 70.78% 70.27% -0.52%
===========================================
Files 75 76 +1
Lines 7267 7401 +134
===========================================
+ Hits 5144 5201 +57
- Misses 2123 2200 +77 |
Collaborator
|
@jjguti This looks like a neat addition. But I think we should add a test to make sure it correctly loops back and only does so if the flag is set. Could You add that? Then, this can be merged. |
Contributor
Author
|
@felixdivo Hi, I have now added a test for the local_loopback flag, please tell me if it's good enough for a merge or if something else should be added. |
Collaborator
|
Thanks for your quick reply! And sorry for the long pause, there is recently quite a backlog of issues/PRs. I think that the test is already nearly complete, but we should add a few lines, see my comments below. |
felixdivo
reviewed
Apr 14, 2021
felixdivo
reviewed
Apr 14, 2021
Collaborator
|
Nice @jjguti! |
felixdivo
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to allow the local loopback to be disabled/enabled on a socketcan interface.