Add typing annotations for ASC module #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works towards PEP 561 compatibility.
Codecov Report
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
+ Coverage 69.74% 69.75% +0.01%
===========================================
Files 70 70
Lines 6590 6599 +9
===========================================
+ Hits 4596 4603 +7
- Misses 1994 1996 +2 |
felixdivo
reviewed
Apr 29, 2020
|
|
||
| def stop(self): | ||
| def stop(self) -> None: | ||
| # This is guaranteed to not be None since we raise ValueError in __init__ |
There was a problem hiding this comment.
Then maybe it should be private?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works towards PEP 561 compatibility.