Skip to content

Implemented Frame.waitForFunction tests #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2018
Merged

Implemented Frame.waitForFunction tests #157

merged 3 commits into from
Apr 20, 2018

Conversation

@Meir017
Copy link
Member

@Meir017 Meir017 commented Apr 19, 2018 •
edited
Loading

closes #139

the following tests aren't relevant for C#:

  • should accept a string (always a string...)
  • should throw on bad polling value (we use an enum)

@Meir017
Copy link
Member Author

Meir017 commented Apr 19, 2018

in puppeteer options.polling in the function waitForFunction can be a number or 'mutation' or 'raf'
not sure yet what the best way would be for us

@Meir017 Meir017 changed the title [WIP] Implemented Frame.waitForFunction tests Implemented Frame.waitForFunction tests Apr 19, 2018
@kblok
Copy link
Member

kblok commented Apr 20, 2018

I like your solution, Polling and PollingInterval

kblok
kblok requested changes Apr 20, 2018
View reviewed changes
Copy link
Member

@kblok kblok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super small nit comment and it's ready to go.

lib/PuppeteerSharp/WaitTask.cs Outdated
{
throw new ArgumentNullException(nameof(predicateBody));
}
if(pollingInterval <= 10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space between if and (

@Meir017
Copy link
Member Author

Meir017 commented Apr 20, 2018

the test PdfDarkskyShouldWork takes between 3 and 30+ seconds...

@kblok kblok merged commit 37ef53e into hardkoded:master Apr 20, 2018
@Meir017 Meir017 deleted the features/frame-wait-for-function branch April 30, 2018 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kblok kblok kblok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Frame.waitforFunction

2 participants

@Meir017 @kblok