Skip to content

Conversation

@harehare
Copy link
Owner

@harehare harehare commented Oct 25, 2025

Added support for skipping the following tokens: Do, Try, LParen and LBrace.

@harehare harehare requested a review from Copilot October 25, 2025 02:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a parser issue by adding additional token types to the target-skipping logic in the CST parser, and optimizes the CI workflow by consolidating tool installations.

Key Changes:

  • Added Do, Try, LParen, and LBrace tokens to the parser's skip target logic to improve error recovery
  • Consolidated CI tool installation steps using taiki-e/install-action@v2 to install multiple tools in a single step

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/mq-lang/src/cst/parser.rs Added four new token types (Do, Try, LParen, LBrace) to the skip target pattern matching for better parser error recovery
.github/workflows/ci.yml Consolidated separate tool installation steps into a single action call with multiple tools

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 25, 2025

CodSpeed Performance Report

Merging #788 will not alter performance

Comparing fix/update_cst_parser_to_add_tokens_for_skipping_target (d5fdef5) with main (064fa66)

Summary

✅ 14 untouched

@harehare harehare merged commit 3d8fa36 into main Oct 25, 2025
6 checks passed
@harehare harehare deleted the fix/update_cst_parser_to_add_tokens_for_skipping_target branch October 25, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant