♻️ refactor(ast): simplify slice expression parsing logic #848
Conversation
Removed unnecessary variable assignment when handling empty slice end bracket (e.g., `[n:]`). This improves code readability without changing functionality.
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the slice expression parsing logic by removing an unnecessary token consumption statement when handling empty slice end expressions (e.g., [n:]). The refactoring eliminates a redundant let _ = self.tokens.next() call and restructures the match arm to directly return the Shared::new(Node {...}) value, improving code readability while maintaining identical functionality.
Key Changes:
- Removed redundant token consumption in the
RBracketmatch arm - Simplified the match arm structure to directly return the parsed node
| )), | ||
| }) | ||
| } | ||
| Some(t) if t.kind == TokenKind::RBracket => Shared::new(Node { |
There was a problem hiding this comment.
The removed self.tokens.next() call was consuming the closing ] bracket. Without this consumption, the ] token remains in the token stream and may cause parsing errors in subsequent operations. The original code correctly consumed the bracket before constructing the node. This removal changes the parser's token stream state and is not just a refactoring.
CodSpeed Performance ReportMerging #848 will not alter performanceComparing Summary
Footnotes |
Removed unnecessary variable assignment when handling empty slice end bracket (e.g.,
[n:]). This improves code readability without changing functionality.