feat: [FFM-12441]: Optimise SSE events #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What** - Updates the InventoryRepo so that it stores the version number of resources along with their redis key. - When fetching config from Saas, we now compare the version of the new resource pulled down with the version stored in the Proxy's inventory. If the new version is greater then we'll add it to the list of notifications, if it isn't then it will be ignroed and no notifications will be sent. **Why** - Previously on startup or restart we would send SSE PATCH events for all events. This forced SDKs to reach out to the Proxy and ensured they had the most recent version incase changes were made in Saas while the Proxy was down. - Now we'll only send patch events for resources that have actually changed while the Proxy was disconnected from Saas.
andybharness
approved these changes
Jul 10, 2025
conormurray95
approved these changes
Jul 10, 2025
jcox250
added a commit
that referenced
this pull request
Jul 10, 2025
jcox250
added a commit
that referenced
this pull request
Jul 10, 2025
jcox250
added a commit
that referenced
this pull request
Jul 10, 2025
jcox250
added a commit
that referenced
this pull request
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Testing
Manually went through the following AC
Acceptance Criteria
Proxy Running
Given I toggle a flag
Then The Proxy should receive an SSE event from Saas, fetch the updated config and store it in redis
And A PATCH SSE event should be forwarded on to my SDK
Given I delete a flag
Then the Proxy should receive a DELETE SSE event and remove the flag from redis
And a DELETE SSE event should be forwarded on to my SDK
Given I create a flag
Then the Proxy should receive a CREATE SSE event from Saas, fetch the config & store it in redis
And a CREATE SSE event should be forwarded on to my SDK
Proxy Disconnected From Saas
Given I delete a flag
When the Proxy reconnects to Saas
Then It should remove the flag from redis & send a DELETE SSE event to SDKs
Given I create a flag
When the Proxy reconnects to Saas
Then it should add the new flag to redis & send a CREATE SSE event to SDKs
Given I patch a flag
When the proxy reconnects to Saas
Then it should update the flags config in redis & send s PATCH sse event