Skip to content

feat: [FFM-12441]: Make inventory repo backwards compatible with older config after #404 #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

feat: [FFM-12441]: Make inventory repo backwards compatible with older config after #404 #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions repository/inventory_repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,29 @@ func (i InventoryRepo) Add(ctx context.Context, key string, assets map[string]in
func (i InventoryRepo) Remove(_ context.Context, _ string) error {
return nil
}

func (i InventoryRepo) Get(ctx context.Context, key string) (map[string]int64, error) {
var inventory map[string]int64
err := i.cache.Get(ctx, string(domain.NewKeyInventory(key)), &inventory)
var (
inventory map[string]int64
inventoryKey = string(domain.NewKeyInventory(key))
)

err := i.cache.Get(ctx, inventoryKey, &inventory)
if err != nil && !errors.Is(err, domain.ErrCacheNotFound) {
return inventory, err
// Backwards compatibility:
// Before PR #404, inventory configs were stored as map[string]string.
// After PR #404, they use map[string]int64 for SSE optimizations.
//
// To support upgrades from older versions (<= 2.0.12), try reading the old format
// and convert it to the new format by setting all values to 0.
backup := map[string]string{}
if err := i.cache.Get(ctx, inventoryKey, &backup); err != nil {
return nil, err
}

for k := range backup {
inventory[k] = 0
}
}

return inventory, nil
Expand Down