Add EnvironmentSensor device #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-f-cruz
requested review from
Poofjunior,
artursilva0,
filcarv and
glopesdev
artursilva0
requested changes
Oct 10, 2024
Contributor
artursilva0
left a comment
artursilva0
left a comment
There was a problem hiding this comment.
I believe the URLs have a typo. Should be: https://github.com/AllenNeuralDynamics/harp.device.environment_sensor
Member
Author
|
@Poofjunior is changing it on our side to keep it standard. That's why I left it as a draft pr for now. I didn't realize GitHub sends the review request when the PR is still in draft stage... sorry! |
filcarv
approved these changes
Oct 10, 2024
artursilva0
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reserves the WhoAmI for the Environment Sensor harp device currently in production at the AIND