Skip to content

Conversation

@mingshuoqiu
Copy link
Contributor

@harvesterhci-io-github-bot
Copy link
Collaborator

harvesterhci-io-github-bot commented May 9, 2024

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit 833dc05
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/664ff8fc4d7a5fbc21abaca3
😎 Deploy Preview https://664ff8fc4d7a5fbc21abaca3--harvester-preview.netlify.app

@mingshuoqiu mingshuoqiu requested review from bk201 and irishgordo May 13, 2024 03:46
@bk201 bk201 requested a review from starbops May 13, 2024 03:47
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingshuoqiu Sorry for the delay. Let me know if you have concerns about the changes.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the setup works. LGTM. Just one nit. Thank you!

The config file declares a subnet and two groups. The first group is for hosts to boot using `CREATE` mode and the other one is for `JOIN` mode. By default, the iPXE path is chosen, but if it sees a PXE client it offers the iPXE image according to the client architecture. Please prepare those images and a TFTP server first.
The Internet Systems Consortium (ISC) announced the final [end-of-life (EOL) for ISC DHCP](https://www.isc.org/blogs/isc-dhcp-eol/) in 2022. ISC DHCP users are encouraged to migrate to the newer, feature-rich [Kea DHCP](https://www.isc.org/kea/), which the ISC designed for more modern network environments. If you are already using the Kea DHCPv4 server, check the following configuration example. For more information, see [Kea DHCPv4 Configuration](https://kea.readthedocs.io/en/kea-1.6.2/arm/dhcp4-srv.html#dhcpv4-server-configuration).
```sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this to json?

If you want to enable UEFI HTTP boot on the Kea DHCPv4 server, you must add a new `client-class` at the end of the `client-classes`.
Example:
```sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Signed-off-by: Chris Chiu <chris.chiu@suse.com>
Copy link
Contributor

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, we can consider add some example to https://github.com/harvester/ipxe-examples too.

@mingshuoqiu mingshuoqiu merged commit 7189f3d into harvester:main May 29, 2024
@mingshuoqiu mingshuoqiu deleted the issue_4618 branch May 29, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants