Skip to content

Showcase: convert modifier/helper integration tests to gts or typescript #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Showcase: convert modifier/helper integration tests to gts or typescript #3366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3a5d6ef
chore: add types for @floating-ui/dom
Nov 14, 2025
b04ba58
feat: convert helpers tests to gts/typescript
Nov 14, 2025
f23eaf6
feat: convert modifiers tests to gts
Nov 14, 2025
68ebc1c
fix: attempt to fix code editor failure
Nov 19, 2025
2a98bf6
try again
Nov 19, 2025
2066543
increase wait time
Nov 19, 2025
5bd0d76
increase time limit?
Nov 19, 2025
b00132d
fixing timeouts
aklkv Nov 20, 2025
cb6e774
chore: organize imports
Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions showcase/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"@embroider/macros": "^1.18.1",
"@embroider/test-setup": "^4.0.0",
"@eslint/js": "^9.27.0",
"@floating-ui/dom": "^1.6.12",
Copy link
Contributor

@didoo didoo Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[issue?] why this is added here?

Copy link
Contributor Author

@shleewhite shleewhite Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added because I needed to import the types for one of the tests: https://github.com/hashicorp/design-system/pull/3366/files#diff-074e93daf2b887754190700afcd3a23549777642058dbac67048a50b832417afR16

"@glimmer/component": "^2.0.0",
"@glimmer/tracking": "^1.1.2",
"@glint/core": "^1.5.2",
Expand Down
16 changes: 13 additions & 3 deletions ...tegration/helpers/hds-format-date-test.js → ...tegration/helpers/hds-format-date-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,27 @@
*/

import { module, test } from 'qunit';
import { setupRenderingTest } from 'showcase/tests/helpers';

import { hdsFormatDate } from '@hashicorp/design-system-components/helpers/hds-format-date';

import { setupRenderingTest } from 'showcase/tests/helpers';

module(
'Integration | Helper | hds-format-date - hdsFormatDate()',
function (hooks) {
setupRenderingTest(hooks);

test('it formats a date with the provided options', async function (assert) {
test('it formats a date with the provided options', function (assert) {
const date = new Date('2021-01-01T00:00:00Z');
const options = {
const options: {
month: Intl.DateTimeFormatOptions['month'];
day: Intl.DateTimeFormatOptions['day'];
year?: Intl.DateTimeFormatOptions['year'];
hour?: Intl.DateTimeFormatOptions['hour'];
minute?: Intl.DateTimeFormatOptions['minute'];
second?: Intl.DateTimeFormatOptions['second'];
timeZoneName?: Intl.DateTimeFormatOptions['timeZoneName'];
} = {
month: 'long',
day: 'numeric',
year: 'numeric',
Expand Down
8 changes: 5 additions & 3 deletions ...ation/helpers/hds-format-relative-test.js → ...ation/helpers/hds-format-relative-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,17 @@
*/

import { module, test } from 'qunit';
import { setupRenderingTest } from 'showcase/tests/helpers';

import { hdsFormatRelative } from '@hashicorp/design-system-components/helpers/hds-format-relative';

import { setupRenderingTest } from 'showcase/tests/helpers';

module(
'Integration | Helper | hds-format-relative - hdsFormatRelative()',
function (hooks) {
setupRenderingTest(hooks);

test('it formats a relative time with the default options', async function (assert) {
test('it formats a relative time with the default options', function (assert) {
const value = -1;
const result = hdsFormatRelative([value]);

Expand All @@ -22,7 +24,7 @@ module(
);
});

test('it formats a relative time with the provided options', async function (assert) {
test('it formats a relative time with the provided options', function (assert) {
const value = -1;
const unit = 'day';
const result = hdsFormatRelative([value, unit]);
Expand Down
15 changes: 8 additions & 7 deletions .../tests/integration/helpers/hds-t-test.gjs → .../tests/integration/helpers/hds-t-test.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
*/

import { module, test } from 'qunit';
import { setupRenderingTest } from 'showcase/tests/helpers';
import { render, setupOnerror } from '@ember/test-helpers';

import hdsT from '@hashicorp/design-system-components/helpers/hds-t';

import { setupRenderingTest } from 'showcase/tests/helpers';

const DEFAULT_STRING = 'Default text';

module('Integration | Helper | hds-t', function (hooks) {
Expand Down Expand Up @@ -49,7 +51,10 @@ module('Integration | Helper | hds-t', function (hooks) {
});

await render(
<template>{{hdsT value default=DEFAULT_STRING}}</template>,
<template>
{{! @glint-expect-error - testing invalid scenarios }}
{{hdsT value default=DEFAULT_STRING}}
</template>,
);

assert.throws(function () {
Expand All @@ -59,11 +64,7 @@ module('Integration | Helper | hds-t', function (hooks) {
});
});

module('ember-intl service is available', function (hooks) {
hooks.beforeEach(function () {
this.intl = this.owner.lookup('service:intl');
});

module('ember-intl service is available', function () {
test('it returns translated string if locale is present and key exists', async function (assert) {
const intl = this.owner.lookup('service:intl');

Expand Down
Loading