Skip to content

Update to use ObjectType from latest spec changes #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2023
Merged

Update to use ObjectType from latest spec changes #17

merged 2 commits into from
Jun 21, 2023

Conversation

@austinvalle
Copy link
Member

@austinvalle austinvalle commented Jun 21, 2023

@austinvalle austinvalle requested a review from a team as a code owner June 21, 2023 14:10
@austinvalle austinvalle mentioned this pull request Jun 21, 2023
Merged
austinvalle
austinvalle commented Jun 21, 2023
View reviewed changes
@austinvalle
Copy link
Member Author

austinvalle commented Jun 21, 2023 •
edited
Loading

None of the golden file e2e tests had an example of an ObjectType, which is only possible with a list of list of objects in the the OpenAPI generator 🙁 . The unit tests did cover this change though 👍🏻

bflad
bflad approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@austinvalle austinvalle merged commit c11cbdd into main Jun 21, 2023
@austinvalle austinvalle deleted the av/update-object-type branch June 21, 2023 15:30
@github-actions
Copy link

github-actions bot commented May 23, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bflad bflad bflad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@austinvalle @bflad