Skip to content

Move shared type validation functions to separate source file and add unit testing #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2022
Merged

Move shared type validation functions to separate source file and add unit testing #26

merged 1 commit into from
May 26, 2022

Conversation

@bflad
Copy link
Contributor

@bflad bflad commented May 25, 2022

Reference: #23 (comment)

@bflad bflad added type/float64 types.Float64 validators type/int64 types.Int64 validators type/string types.String validators labels May 25, 2022
@bflad bflad added this to the v0.2.0 milestone May 25, 2022
@bflad bflad requested a review from a team as a code owner May 25, 2022 16:55
bendbennett
bendbennett approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

detro
detro approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳 😘 this is awesome, and with additional unit tests!

@bflad bflad merged commit 7c732e8 into main May 26, 2022
@bflad bflad deleted the bflad-type-validation-refactoring branch May 26, 2022 21:58
@github-actions
Copy link

github-actions bot commented Jun 26, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@detro detro detro approved these changes

@bendbennett bendbennett bendbennett approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/float64 types.Float64 validators type/int64 types.Int64 validators type/string types.String validators

Projects

None yet

Milestone

v0.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bflad @detro @bendbennett