Skip to content

Conversation

@stephybun
Copy link
Member

Description

Updates the proto definitions for 5 and 6 to validate include_resource and limit

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

None

@stephybun stephybun requested a review from a team as a code owner July 16, 2025 12:11
@stephybun stephybun enabled auto-merge (squash) July 16, 2025 13:55
Copy link
Contributor

@bbasata bbasata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:


// IncludeResourceObject is the value of the include_resource
// argument in the list block. This is a DynamicValue so that it can
// contain unknown values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my first look at the updated proto files, so the DynamicValues for primitive-or-unknown in the protocol surprised me. It feels like a rare example/precedent – a DynamicValue typically represents a value with a provider-defined schema type.

I do recall the discussion of allowing expressions in config, so this may indeed be necessary. My one thought here is to consider how to simplify access to these fields in Framework – and possibly plugin-go too – for the provider developer.

@stephybun stephybun merged commit cf99b16 into main Jul 16, 2025
96 checks passed
@stephybun stephybun deleted the f/add-offline-list-validation branch July 16, 2025 13:59
@bbasata bbasata added this to the v0.29.0 milestone Jul 16, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants