-
Notifications
You must be signed in to change notification settings - Fork 17
Update ExpectKnownValue query check to use queryfilter and accept multiple knownvalue checks
#583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
austinvalle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach makes sense to me, I do have a couple small nits, but also one clarification about the early exiting of the check that didn't seem intentional.
b0aba17 to
b2d2040
Compare
ansgarm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Related Issue
Closes #563
Description
This PR updates the existing
querycheck.ExpectKnownValuecheck to be more consistent with the way a query check functions and is named after the introduction of a lookup mechanism introduced by #573The following changes were made:
ExpectKnownValuecheck was updated to accept and use aqueryfilterto find the relevant resource for assertions instead of the display name which may not always be unique or known beforehandquerycheck.KnownValuesCheckwas introduced to be able to specify multiple known value checksquerycheck.ExpectResourceKnownValuesto better reflect what the check is capable ofRollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
None.