This repository was archived by the owner on Dec 9, 2020. It is now read-only.
r/site: support "account_slug" to create site in team #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
appilon
approved these changes
Feb 25, 2019
Contributor
appilon
left a comment
appilon
left a comment
There was a problem hiding this comment.
Approved, i fixed that travis issue
|
I did't see this and create my own PR with the same #34 |
|
Any update? |
paultyng
approved these changes
Feb 5, 2020
shsamkit
added a commit
to shsamkit/terraform-provider-netlify
that referenced
this pull request
Jun 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to create a site within a specific "team" in Netlify.
We need this particularly at HashiCorp since we want to use the provider to create the site directly into our "hashicorp" team.
Why aren't there any tests?!! To test this, you'd need to either have a team already or create a team dynamically. We can't do the latter (create dynamically) because there is no free tier for teams, so you need to setup payments and all that all via the API which is nasty and would also require us to know CC details somehow. We can't reliably do the former since that requires our test account to have a team setup. I could add a test with an env var check here but I thought maybe because the code paths are so similar it might be okay?
I built and tested the resource manually and it worked.