VAULT: 36221 start time counters api bug #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vercel Previews Deployed
|
Contributor
Broken Link CheckerNo broken links found! 🎉 |
yhyakuna
approved these changes
Jul 29, 2025
schavis
requested changes
Jul 31, 2025
content/vault/v1.18.x/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.19.x/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.19.x/content/partials/release-notes/change-summary/1_19.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.18.x/content/docs/upgrading/upgrade-to-1.18.x.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.19.x/content/docs/updates/important-changes.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.19.x/content/docs/updates/important-changes.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
….mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
…mmary/1_19.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
…s.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
…s.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
schavis
reviewed
Aug 1, 2025
Contributor
schavis
left a comment
schavis
left a comment
There was a problem hiding this comment.
Sorry I missed the OSS strings in the headers. Feel free to ping me when it's updated and I'll approve
content/vault/v1.18.x/content/docs/upgrading/upgrade-to-1.18.x.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.19.x/content/docs/updates/important-changes.mdx
Outdated
Show resolved
Hide resolved
….mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Contributor
Author
It's okay, thank you for catching these! |
Contributor
Author
|
@schavis pinging you for another look:) |
schavis
approved these changes
Aug 5, 2025
aslamovamir
deleted the
aslamovamir-vault-36221-start-time-counters-api-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the docs around the known issues with the
start_timeparameter leading to infinite loops as a bug when not provided to the Counters API. After investigation, we found this affects only Vault version 1.18.x and 1.19.x and has been fixed in 1.20.0. This PR accordingly updates docs around Counters API, release notes and upgrade docs for the affected Vault versions.Jira: https://hashicorp.atlassian.net/browse/VAULT-36221
Manual test snapshots: