-
Notifications
You must be signed in to change notification settings - Fork 90
Vault Export api changes to add first used timestamp column in query period docs change #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Vercel Previews Deployed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Broken Link Checker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions, but otherwise looks good to me.
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks like token creation time is the creation time of the token that was used to perform the request for the client and this necessarily need not be the first ever token created for the client. I modified the description as part of commit 704966f |
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Outdated
Show resolved
Hide resolved
|
||
- `client_first_usage_time` in the response is a timestamp that represents the earliest usage of the client during the queried time period. | ||
|
||
- **`sudo` required** – This endpoint requires `sudo` capability in addition to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest deleting the sudo line in favor of using the restricted endpoint partial directly below the "Activity export" heading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is more of a policy capability rather than a root-restricted endpoint
content/vault/v1.21.x (rc)/content/api-docs/system/internal-counters.mdx
Show resolved
Hide resolved
…unters.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
…unters.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Jira: https://hashicorp.atlassian.net/browse/VAULT-37796
Adds client_first_usage_time to export api
Looks like token_creation_time ce changes are not present in this repo. Added those changes too https://github.com/hashicorp/vault/pull/31149/files