fix: prebuild script adds release stage to versions in nav-data files and internal links #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vercel Previews Deployed
|
im2nguyen
approved these changes
Sep 3, 2025
RubenSandwich
approved these changes
Sep 3, 2025
Contributor
There was a problem hiding this comment.
Looks good.
But we really should add some tests to this file in the future. 🤔
Edit: Right after I wrote this I wanted to test inline links and discovered an issue: #901 (review).
RubenSandwich
requested changes
Sep 3, 2025
Contributor
There was a problem hiding this comment.
Actually I just discovered another problem, that likely already existed, inline links have the release stage in them too:
- go to: https://unified-docs-frontend-preview-91j9uuugd-hashicorp.vercel.app/terraform/language/v1.14.x/syntax/json
- click on the link "the native Terraform language syntax"
- The URL still has the release stage in it, so it 404s
So I think we are missing another transform as well. 😢
LeahMarieBush
changed the title
| expect(result).toBe(expectedOutput) | ||
| }) | ||
|
|
||
| it('should remove release stage in parentheses from version', async () => { |
RubenSandwich
approved these changes
Sep 4, 2025
Contributor
There was a problem hiding this comment.
Awesome work!
I even checked an image in an alpha release just in case: https://unified-docs-frontend-preview-g9nr4t65d-hashicorp.vercel.app/terraform/cli/v1.14.x/commands/graph, and that worked. 😌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Asana task 🎟️
This PR fixes the prebuild nav data and internal links transforms. Currently, it gets the version from the folder name and appends that version for the sidebar and internal links. For versions with a release stage (ex. alpha, beta), we want to remove the stage from the version before appending the version for the links.
Testing