Skip to content

Conversation

@rizary
Copy link
Collaborator

@rizary rizary commented Jun 2, 2019

This PR related to #57 issue.

@rizary rizary requested a review from hvr June 2, 2019 14:25
@rizary
Copy link
Collaborator Author

rizary commented Jun 2, 2019

There are at least 2 bugs at this commit:
1. When clicking adding tag button, it returns 401 unauthorized without create login/pass pop up similar to what UI v2 does. This is similar to when clicking queue button.
2. When clicking adding tag button, the url changes from ng/#/package/ace into ng/?#/package/ace, which adding ? in the url address. But when we refresh the browser, the page still works.

regarding number 2, I'm still finding the root cause of that weird behavior.

Maybe I'll create another issue on this.

@hvr hvr merged commit d4ebff6 into haskell-CI:master Jun 11, 2019
hvr added a commit that referenced this pull request Jun 11, 2019
@rizary rizary deleted the v3-tags branch June 13, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants