Fix PwdHash tests, review and refactor PwdHash modules
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix parameter ordering for Scrypt and Argon2 testcases * Change i, j, k to more descriptive names of the parameters * Add comments where to find the parameter orders from Botan's C++ code
6 tasks
jorisdral
force-pushed
the
jdral/pwdhash
branch
from
f80b668 to
41d03ce
Compare
This includes only the relevant modules from `botan-bindings` and `botan-low`. The main changes do not affect the functionality of the code. The existing tests are expanded upon.
jorisdral
force-pushed
the
jdral/pwdhash
branch
from
41d03ce to
4ffc430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from #22 are included in this PR. This PR resolves part of #33.
As a side project, I have reviewed and refactored the
PwdHashmodules. This includes only the relevant modules frombotan-bindingsandbotan-low. The main changes do not affect the functionality of the code. The existing tests are expanded upon.