Fix a bug in public-key encrypt and decrypt functions
#79
+46
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/fix-encrypt-test
branch
from
0632d98 to
2271d62
Compare
We now use upper bounds on output buffer sizes as provided by the Botan C FFI to allocate buffers, rather than querying the encryption/decryption fuctions with a null pointer (see randombit/botan#5154), which are arguably suffering from a bug. Using the upper bounds was already advised by the Botan C FFI anyway.
jorisdral
force-pushed
the
jdral/fix-encrypt-test
branch
from
2271d62 to
f0a4964
Compare
jorisdral
changed the title
Test.Botan.Low.PubKey.Encryptencrypt and decrypt functions
6 tasks
jorisdral
added
botan-low
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a part of #33. See the commit message for more information.