Skip to content

Fix PubKey.DSA tests #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

Fix PubKey.DSA tests #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 3 additions & 25 deletions botan-low/test/Test/Botan/Low/PubKey/DSA.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,34 +18,12 @@ tests = do
specs <- testSpec "spec_dsa" spec_dsa
pure $ testGroup "Test.Botan.Low.PubKey.DSA" [
specs
-- TODO: temporarily disabled because the test suite fails. See issue
-- #33.
| False
]

-- TODO: Consolidate
dlGroups :: [ByteString]
dlGroups =
[ "ffdhe/ietf/2048"
, "ffdhe/ietf/3072"
, "ffdhe/ietf/4096"
, "ffdhe/ietf/6144"
, "ffdhe/ietf/8192"
, "modp/ietf/1024"
, "modp/ietf/1536"
, "modp/ietf/2048"
, "modp/ietf/3072"
, "modp/ietf/4096"
, "modp/ietf/6144"
, "modp/ietf/8192"
, "modp/srp/1024"
, "modp/srp/1536"
, "modp/srp/2048"
, "modp/srp/3072"
, "modp/srp/4096"
, "modp/srp/6144"
, "modp/srp/8192"
, "dsa/jce/1024"
[ "dsa/jce/1024"
, "dsa/botan/2048"
, "dsa/botan/3072"
]
Expand Down Expand Up @@ -73,7 +51,7 @@ spec_dsa :: Spec
spec_dsa = testSuite dlGroups chars $ \ dlGroup -> do
it "privKeyLoadDSA" $ do
rng <- rngInit "system"
privKey <- privKeyCreate "DH" dlGroup rng
privKey <- privKeyCreate "DSA" dlGroup rng
p <- privKeyField privKey "p"
q <- privKeyField privKey "q"
g <- privKeyField privKey "g"
Expand All @@ -82,7 +60,7 @@ spec_dsa = testSuite dlGroups chars $ \ dlGroup -> do
pass
it "pubKeyLoadDSA" $ do
rng <- rngInit "system"
privKey <- privKeyCreate "DH" dlGroup rng
privKey <- privKeyCreate "DSA" dlGroup rng
pubKey <- privKeyExportPubKey privKey
p <- pubKeyField pubKey "p"
q <- pubKeyField pubKey "q"
Expand Down