-
Notifications
You must be signed in to change notification settings - Fork 2
runInTerminal support #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dmjio I'm using this change in the debugger successfully. Perhaps you'd like to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but wondering if we can reuse send
here.
Exposes 'sendRunInTerminalReverseRequest' helper too.
5ec87b6
to
9457d40
Compare
@dmjio I've simplified according to your suggestions. I was also wondering about (Currently, the code assumes the server will only ever send requests, but with reverse requests it will also send reverse request responses) The issue is the Why have the Let me try this quickly... |
Ah, I see the point. We only have a Request in the environment when replying to a request. Notably, we don't have one in |
Extends the entrypoint runDAPWithLogger function to accept a function which is called on `ReverseRequestResponse`s, a response to a reverse request. This allows the DAP server to e.g. capture the PID of the process invoked via `runInTerminal`.
@dmjio I've added a third commit to allow receiving reverse-request-responses. Let me know what you think. |
@dmjio I've also updated the CHANGELOG and bumped the version hoping we could do another 0.x.0.0 release with the added capability. |
I think |
Fixes #15