Skip to content

Conversation

@Anton-Latukha
Copy link
Collaborator

@Anton-Latukha Anton-Latukha commented Dec 29, 2020

For quite some time 8.8 strict build fails:

src/Nix/Expr/Types.hs:179:10: error: [-Wmissing-methods, -Werror=missing-methods]
    • No explicit implementation for
        ‘liftTyped’
    • In the instance declaration for ‘Lift (Fix NExprF)’
    |
179 | instance Lift (Fix NExprF) where
    |          ^^^^^^^^^^^^^^^^^

nomissing-methods seems like a bad path in this case and module.

I am quite new with Template Haskell, I tried to address the issue and so far not constructed the implementation. I think more TH knowledge is needed.

Too bad that the issue creeped-up backwards. Strict builds worked until this one popped-up.

So lowering the CI strictness until this gets resolved.

For quite some time 8.8 strict build fails:
```
src/Nix/Expr/Types.hs:179:10: error: [-Wmissing-methods, -Werror=missing-methods]
    • No explicit implementation for
        ‘liftTyped’
    • In the instance declaration for ‘Lift (Fix NExprF)’
    |
179 | instance Lift (Fix NExprF) where
    |          ^^^^^^^^^^^^^^^^^
```

`nomissing-methods` seems like a bad path in this case and module.

I tried to adddess the issue and so far not constructed the implementation.

Too bad that the issue creaped-up backwards. Strict builds worked until this one
cropped-in.

So lowering the CI strictness until this gets resolved.
@Anton-Latukha Anton-Latukha merged commit f4ef25b into master Dec 29, 2020
@Anton-Latukha Anton-Latukha deleted the 2020-12-29-CI-make-GHC-8.8-build-nonstrict branch December 29, 2020 16:02
@Anton-Latukha Anton-Latukha mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants