Switching (hacky->principled) functions for the string context #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Latukha
changed the title
This was
linked to
issues
Jan 7, 2021
Closed
Structuring, sorting things arround.
Anton-Latukha
force-pushed
the
2021-01-07-erradication-of-the-hackyStringContexts
branch
from
bceec15 to
f81cd78
Compare
Collaborator
Author
|
Think I would stop, it is already enough for one patch. |
Collaborator
Author
|
Ok. I want to treat the orphaned instances next. I would merge this on the grounds that it is a clean-up refactor. There is no changes in the functionality, except that NixString now is a proper Monoid & that it is leveraged now. There is an undercurrent processed that would help us and downstream to ease the interface transitions. I need to annotate all these interface transitions. |
Anton-Latukha
deleted the
2021-01-07-erradication-of-the-hackyStringContexts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: Replace all occurrences of
hackyMakeNixStringWithoutContextwithprincipled...versions. #383 Replace all occurrences ofhackyStringIgnoreContextwithprincipled...versions. #384 Replace all occurrences ofhackyGetStringNoContextwithprincipled...versions. #385Reduced prefixes from functions.
Code now treats the NixString as a monoid.