Export orphan ST Applicative instance from base-orphans #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, but I'm not going to take this patch without evidence that our orphan instance (for ghc 7.0 and below, which nobody should be using anymore anyway) is actually hurting users. As far as I can see, this patch fixes a non-issue by adding a dependency whose versions we'd have to track, which means an overall loss in maintainability. |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces
union-find-array's orphanApplicative STinstance with one exported from thebase-orphanslibrary. This helps mitigate the possibility of other libraries defining anApplicative STinstance and failing to compile if used together withunion-find-arrayon early versions of GHC.