Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there --show-details analog for new-test command? #4766

Closed
vagarenko opened this issue Sep 14, 2017 · 8 comments
Closed

Is there --show-details analog for new-test command? #4766

vagarenko opened this issue Sep 14, 2017 · 8 comments
Labels
cabal-install: nix-local-build type: enhancement

Comments

@vagarenko
Copy link

Is there --show-details analog for new-test command?

> cabal new-test --show-details=streaming
cabal: unrecognized 'new-test' option `--show-details=streaming'
@23Skidoo
Copy link
Member

It's probably not implemented yet.

/cc @ttuegel @fgaz

@fgaz
Copy link
Member

fgaz commented Sep 19, 2017

Yeah, we don't have support for test and bench specific flags in new-build yet. See #4643 too.
It's probably just a matter of passing them to the right function, but I have yet to investigate.

@ttuegel
Copy link
Member

ttuegel commented Sep 19, 2017

It's probably not implemented yet.

I think that we should not implement this. Instead, we should just make the --show-details=streaming behavior the only one supported by new-test.

It was a huge mistake to try to support logging this way in Cabal itself. If you are doing logging during build, it is almost certainly because you are doing CI, but Cabal is not a CI tool! If you want test logging, there are other, better tools. Test frameworks tend to misbehave unless run with --show-details=streaming; we should never have tried to do anything else.

@fgaz fgaz mentioned this issue Oct 22, 2017
Closed
@quasicomputational quasicomputational mentioned this issue Jul 11, 2018
Merged
9 tasks
@quasicomputational
Copy link
Contributor

+1 to defaulting to streaming for new-test, whether or not it's the only behaviour. It's happened more than once now that I've misdiagnosed slow tests as a hang because of this.

nomeata added a commit to nomeata/incredible that referenced this issue Jul 24, 2018
@nomeata
No --show-details=streaming in new-test?
571b92b 
not according to haskell/cabal#4766
but I agree with the discussion that streaming is the right default. I
want my colors!
nomeata added a commit to nomeata/incredible that referenced this issue Jul 24, 2018
@nomeata
Squashed commit of the following:
40cbf23 
commit 571b92b
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Jul 23 21:53:28 2018 -0400

    No --show-details=streaming in new-test?

    not according to haskell/cabal#4766
    but I agree with the discussion that streaming is the right default. I
    want my colors!

commit 0b734b3
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Jul 23 18:41:16 2018 -0400

    Add overlay

commit 61633ce
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Jul 23 18:23:20 2018 -0400

    Clean environment files

commit cb4ad3c
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Jul 23 18:21:51 2018 -0400

    Forgot CABAL_FLAGS

commit 0ec1eee
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Jul 23 17:35:17 2018 -0400

    Try cabal head

commit 59e9618
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Jul 23 16:36:59 2018 -0400

    Install ghc-8.2.2 explicitly

commit c4bd98a
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Jul 23 16:32:32 2018 -0400

    Install ghc-8.2.1 explictily

commit 54f5a20
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Jul 23 16:29:07 2018 -0400

    Upgrade to GHC(JS)-8.2

    and use the GHCJS PPA

commit e961c5f
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Sat Sep 16 21:18:02 2017 -0400

    Typo in Makefile

commit c02c793
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Sat Sep 16 15:06:17 2017 -0400

    Bump base dependency for ghc-8.0

commit 3aa966e
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Sat Sep 16 14:34:39 2017 -0400

    Install hsc2hs

commit 42719f9
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Sat Sep 16 14:30:53 2017 -0400

    Try different PATH

commit 5da17d3
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Sat Sep 16 13:10:01 2017 -0400

    Try Cabal-1.24

commit 994f2d2
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Sat Sep 16 12:13:49 2017 -0400

    Install ghc-8.0 branch of ghcjs

commit 0da65c6
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Sat Sep 16 12:12:58 2017 -0400

    Install current ghc

commit 15c858b
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Sat Sep 16 12:11:01 2017 -0400

    Install current ghc

commit 69c9da6
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Sat Sep 16 12:10:42 2017 -0400

    Install current Cabal

commit 8ec52aa
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Fri Sep 15 16:00:56 2017 -0400

    Try to bump ghcjs

commit c920d6f
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 22:56:14 2017 +0100

    No cabal for ghcjs

commit dfeb8cf
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 22:27:28 2017 +0100

    reorder

commit 36d20b8
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 19:16:19 2017 +0100

    sigh…

commit aa75457
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 18:04:31 2017 +0100

    Try new Cabal also in ghcjs

commit a4e4c45
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 17:44:26 2017 +0100

    Try to avoid newer versions of distributive

commit cdc008b
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 17:29:59 2017 +0100

    Try --force-reinstalls

commit c0c5f0d
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 17:15:35 2017 +0100

    More stages

commit e3603a9
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 17:14:30 2017 +0100

    Try to use an old version of distributive

commit 0421a82
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 16:40:17 2017 +0100

    Try Cabal 2.0

commit a4df414
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 15:55:21 2017 +0100

    Always run cabal update

commit 05481d1
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 14:58:56 2017 +0100

    More useful `script` commands

commit f78b527
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 14:32:57 2017 +0100

    true instead of pass

commit c4016b4
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 13:57:21 2017 +0100

    install jshint in main stage

commit c1dee8d
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 13:50:03 2017 +0100

    Try to use stages

commit adf22f5
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 13:44:06 2017 +0100

    Try to build incrementally

commit 9d2b186
Author: Joachim Breitner <mail@joachim-breitner.de>
Date:   Mon Sep 4 13:16:05 2017 +0100

    Wiggle travis settings
@nomeata
Copy link
Contributor

nomeata commented Jul 24, 2018

Incidentally, this question has hit StackExchange today:
https://stackoverflow.com/q/51488620/946226

@harpocrates harpocrates mentioned this issue Jul 24, 2018
Merged
3 tasks
@23Skidoo 23Skidoo mentioned this issue Oct 12, 2018
Closed
@michalrus
Copy link

michalrus commented Oct 24, 2018 •
edited
Loading

A simple solution for the time being:

cabal new-build integration

$(find dist-newstyle -name integration -executable -type f) --color=always

… assuming your test suite is named integration.

/cc @harendra-kumar

@harendra-kumar
Copy link

@michalrus yes, manually running the test executable works, I do it sometimes, its just a bit inconvenient. However, it does not work in a generic CI script (e.g. I use https://github.com/harendra-kumar/packcheck) where the test suite names are not known. We can perhaps ask cabal to list the test suite names or parse the cabal file, but then we are just building a poor workaround for the functionality ourselves.

@fgaz
Copy link
Member

fgaz commented Oct 25, 2018

@michalrus if you want to run a single test you can also use cabal new-run integration -- --color=always

harpocrates added a commit that referenced this issue Nov 12, 2018
@harpocrates
Port 'TestFlags' to 'new-test' (#5455)
de5d2c5 
This means that old `test` flags can be passed in to `new-test`, `new-build`, `new-install`,
`new-configure`, etc. These new flags are:

    * `--test-log` (see old `--log`)
    * `--test-machine-log` (see `--machine-log`)
    * `--test-show-details` (see `--show-details`)
    * `--test-keep-tix-files` (see `--keep-tix-files`)
    * `--test-options`
    * `--test-option`

This fixes #4803, #4643, #4766, and #5416.
@gwils gwils mentioned this issue Feb 1, 2019
Closed
lfborjas added a commit to lfborjas/swiss-ephemeris that referenced this issue Sep 5, 2020
@lfborjas
Stream cabal test output
ff2de2a 
`direct` was disowned in:
haskell/cabal#4766 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cabal-install: nix-local-build type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@23Skidoo @nomeata @ttuegel @vagarenko @michalrus @harendra-kumar @fgaz @quasicomputational