Fix v2-install ProgramDb confusion #6195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
FYI this also needs a backport to the 3.0 branch if we're intending to cut a cabal-install release from that eventually. |
phadej
suggested changes
Aug 19, 2019
Commit 273dacf ("Extract installLibraries and InstallExes from installAction") makes 'getInstalledPackages' get passed the pre-configCompilerEx ProgramDb which will cause pattern match failures when the code tries to lookup ghc-pkg in the progdb.
DanielG
force-pushed
the
fix-v2-install-progdb
branch
from
ba009ec to
1ad6c0f
Compare
phadej
approved these changes
Aug 22, 2019
Member
|
/cc @fgaz |
23Skidoo
pushed a commit
that referenced
this pull request
Aug 27, 2019
Fix v2-install ProgramDb confusion (cherry picked from commit a7a9766)
23Skidoo
pushed a commit
that referenced
this pull request
Aug 27, 2019
Fix v2-install ProgramDb confusion (cherry picked from commit a7a9766)
Member
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 273dacf ("Extract installLibraries and InstallExes from
installAction") makes 'getInstalledPackages' get passed the
pre-
configCompilerExProgramDb which will cause pattern match failures whenthe code tries to lookup ghc-pkg in the progdb.
As far as I can tell on master currently any
v2-installinvocation would fail withbut I only tested with
cabal v2-install --lib Cabal-3.0.0.0.Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.