Skip to content

Commit bdc0493

Browse files
committed
http-client >= 0.5
1 parent 2e8821e commit bdc0493

File tree

2 files changed

+1
-21
lines changed

2 files changed

+1
-21
lines changed

hackage-security-http-client/hackage-security-http-client.cabal

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ library
2020
build-depends: base >= 4.4,
2121
bytestring >= 0.9,
2222
data-default-class >= 0.0,
23-
http-client >= 0.4 && < 0.6,
23+
http-client >= 0.5 && < 0.6,
2424
http-types >= 0.8,
2525
hackage-security >= 0.5 && < 0.6
2626
hs-source-dirs: src

hackage-security-http-client/src/Hackage/Security/Client/Repository/HttpLib/HttpClient.hs

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
{-# LANGUAGE CPP #-}
21
{-# LANGUAGE OverloadedStrings #-}
32
module Hackage.Security.Client.Repository.HttpLib.HttpClient (
43
withClient
@@ -17,10 +16,6 @@ import qualified Network.HTTP.Client as HttpClient
1716
import qualified Network.HTTP.Client.Internal as HttpClient
1817
import qualified Network.HTTP.Types as HttpClient
1918

20-
#if !MIN_VERSION_http_client(0,4,30)
21-
import Data.Default.Class (def)
22-
#endif
23-
2419
import Hackage.Security.Client hiding (Header)
2520
import Hackage.Security.Client.Repository.HttpLib
2621
import Hackage.Security.Util.Checked
@@ -60,11 +55,7 @@ get :: Throws SomeRemoteError
6055
get manager reqHeaders uri callback = wrapCustomEx $ do
6156
-- TODO: setUri fails under certain circumstances; in particular, when
6257
-- the URI contains URL auth. Not sure if this is a concern.
63-
#if MIN_VERSION_http_client(0,4,30)
6458
request' <- HttpClient.setUri HttpClient.defaultRequest uri
65-
#else
66-
request' <- HttpClient.setUri def uri
67-
#endif
6859
let request = setRequestHeaders reqHeaders
6960
$ request'
7061
checkHttpException $ HttpClient.withResponse request manager $ \response -> do
@@ -77,11 +68,7 @@ getRange :: Throws SomeRemoteError
7768
-> (HttpStatus -> [HttpResponseHeader] -> BodyReader -> IO a)
7869
-> IO a
7970
getRange manager reqHeaders uri (from, to) callback = wrapCustomEx $ do
80-
#if MIN_VERSION_http_client(0,4,30)
8171
request' <- HttpClient.setUri HttpClient.defaultRequest uri
82-
#else
83-
request' <- HttpClient.setUri def uri
84-
#endif
8572
let request = setRange from to
8673
$ setRequestHeaders reqHeaders
8774
$ request'
@@ -94,17 +81,10 @@ getRange manager reqHeaders uri (from, to) callback = wrapCustomEx $ do
9481
callback HttpStatus200OK (getResponseHeaders response) br
9582
_otherwise ->
9683
throwChecked $
97-
#if MIN_VERSION_http_client(0,5,0)
9884
HttpClient.HttpExceptionRequest request' $
9985
HttpClient.StatusCodeException
10086
(void response)
10187
BS.empty
102-
#else
103-
HttpClient.StatusCodeException
104-
(HttpClient.responseStatus response)
105-
(HttpClient.responseHeaders response)
106-
(HttpClient.responseCookieJar response)
107-
#endif
10888

10989
-- | Wrap custom exceptions
11090
--

0 commit comments

Comments
 (0)