Why does CodeActionProvider take PluginId

[alanz]

We have

type CodeActionProvider =  PluginId
                        -> VersionedTextDocumentIdentifier
                        -> Range
                        -> CodeActionContext
                        -> IdeM (IdeResult [CodeAction])

But each of these is provided in a PluginDescriptor. Is there any reason to have the first parameter (PluginId)?

[lukel97]

Looks like it comes down to mkLspCommand taking the plugin id. I agree it seems redundant to pass it through to both PluginDescriptor and CodeActionProvider. Is there any way we could embed it in mkLspCommands monad?

[alanz]

Ok, that is a good reason to have it. I think keeping it as it is is fine, no need to add extra complexity. I guess I should add a comment on it though.

It's amazing how quickly you forget the reasons for code. Which means documenting stuff gets more and more important, for long-lived code. Which this is becoming.