Use new cabal-helper

[lukel97]

This removes cabal-helper-wrapper, and so will open up the way for static binaries until hie-bios lands.
Also noticeably, it removes the build plugin since it relied on the old cabal-helper API: I plan on removing this in #1105 anyway as it is only used by the old JSON transport.

Please dogfood this a bit!

[lukel97]

@alanz this is all using your work on new-cabal-helper with ghc-mod, should I create a PR to merge this into your fork?

[alanz]

For the HaRe tests I copy certain projects to $TEMPDIR/testproj, and then work with that. This looks like a very brittle hard coded path.

[lukel97]

I never even noticed the path, I just copied and pasted it verbatim. Will do a fuzzier expectation

[fendor]

While the stability seems to be improved in general, it reopens #1264, probably since the patch for it was submitted after this pr had been opened.
Patch was in https://github.com/alanz/ghc-mod/pull/20/files (only the changes to ModuleLoader.hs)

[fendor]

When you open haskell-ide-engine repository, you no longer get diagnostics for modules in the sub-package hie-plugin-api. Instead, it fails with the error message, when I open TypeMap.hs:

/home/user/Documents/haskell/bubba-hie/hie-plugin-api/stack.yaml: getFileStatus: does not exist (No such file or directory)

[NickSeagull]

What's missing for this to be merged? I see that the cabal job has passed, but the others are failing with some allow-newer errors. I guess this is due to the version bump of cabal-helper?

I'd love to help in order to get this merged

[lukel97]

The cabal job is passing just because the cabal job doesn’t run any tests 😬 The first thing would be to probably get the remaining tests passing locally, and from what I can remember there were some new problems when working with cabal projects nested within each other, like @fendor pointed out above with the hie-plugin-api sub-project in haskell-ide-engine itself. PRs to this branch are more than welcome! :)

…

On 10 Sep 2019, at 16:53, Nick Tchayka ***@***.***> wrote: What's missing for this to be merged? I see that the cabal job has passed, but the others are failing with some allow-newer errors. I guess this is due to the version bump of cabal-helper? I'd love to help in order to get this merged — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[lukel97]

This is done in hie-bios