Nix Expression: Build fails

[GuillaumeDesforges]

I am currently adding haskell-language-server to nixpkgs: NixOS/nixpkgs#91279

I have errors (see NixOS/nixpkgs#91279 (comment)):

Building library for haskell-language-server-0.1.0.0..
[ 1 of 17] Compiling Ide.Logger       ( src/Ide/Logger.hs, dist/build/Ide/Logger.o )
[ 2 of 17] Compiling Ide.Cradle       ( src/Ide/Cradle.hs, dist/build/Ide/Cradle.o )
[ 3 of 17] Compiling Ide.Plugin.Config ( src/Ide/Plugin/Config.hs, dist/build/Ide/Plugin/Config.o )
[ 4 of 17] Compiling Ide.PluginUtils  ( src/Ide/PluginUtils.hs, dist/build/Ide/PluginUtils.o )
[ 5 of 17] Compiling Ide.Types        ( src/Ide/Types.hs, dist/build/Ide/Types.o )
[ 6 of 17] Compiling Ide.Plugin.Formatter ( src/Ide/Plugin/Formatter.hs, dist/build/Ide/Plugin/Formatter.o )

src/Ide/Plugin/Formatter.hs:67:33: error:
    • Couldn't match expected type ‘shake-0.19:Development.Shake.Internal.Core.Types.Action
                                      (FileVersion, Maybe T.Text)
                                    -> IO (a1, Maybe T.Text)’
                  with actual type ‘IO a0’
    • The first argument of ($) takes one argument,
      but its type ‘IO a0’ has none
      In a stmt of a 'do' block:
        (_, mb_contents) <- runAction "Formatter" ideState
                              $ getFileContents fp
      In the expression:
        do (_, mb_contents) <- runAction "Formatter" ideState
                                 $ getFileContents fp
           case mb_contents of
             Just contents -> do ...
             Nothing
               -> return
                    $ Left
                        $ responseError
                            $ T.pack
                                $ "Formatter plugin: could not get file contents for " ++ show uri
   |
67 |             (_, mb_contents) <- runAction "Formatter" ideState $ getFileContents fp
   |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/Ide/Plugin/Formatter.hs:67:55: error:
    • Couldn't match expected type ‘shake-0.19:Development.Shake.Internal.Core.Types.Action
                                      a0’
                  with actual type ‘IdeState’
    • In the second argument of ‘runAction’, namely ‘ideState’
      In the expression: runAction "Formatter" ideState
      In a stmt of a 'do' block:
        (_, mb_contents) <- runAction "Formatter" ideState
                              $ getFileContents fp
   |
67 |             (_, mb_contents) <- runAction "Formatter" ideState $ getFileContents fp
   |                                                       ^^^^^^^^
[16 of 17] Compiling Paths_haskell_language_server ( dist/build/autogen/Paths_haskell_language_server.hs, dist/build/Paths_haskell_language_server.o )
[17 of 17] Compiling Ide.Version      ( src/Ide/Version.hs, dist/build/Ide/Version.o )

[fendor]

How are you building HLS?
Did you update the git submodule?

[GuillaumeDesforges]

How are you building HLS?

I am using Nix. You can see my PR here: NixOS/nixpkgs#91279

Did you update the git submodule?

I am building using Nix, so my build is from scratch. I believe it fetches the git submodules as it should. Do you want me to perform a specific check?

Looking at

    • Couldn't match expected type ‘shake-0.19:Development.Shake.Internal.Core.Types.Action
                                      (FileVersion, Maybe T.Text)
                                    -> IO (a1, Maybe T.Text)’
                  with actual type ‘IO a0’

Maybe there is an issue with shake ? I see no upper bound on the package dependencies.
I am using version 0.19

[fendor]

I am using version 0.19

Should be fine, in our build-plan we are using 0.19.1

---

I think you are using ghcide from nixpkgs which is different to the branch we are using.
I dont know how to do it exactly, but you need to include the submodule. I think cabal2nix cant handle this.

[GuillaumeDesforges]

I think you are using ghcide from nixpkgs which is different to the branch we are using.

I see, thanks for the tip! I'll try to fix that.

[GuillaumeDesforges]

Seems like it can now build, thanks