hie.yaml files in the parent directory are incorrectly used

[expipiplus1]

I've made a minimal repro here https://github.com/expipiplus1/hie-yaml-find

Your environment

haskell-language-server-wrapper --version
haskell-language-server version: 1.8.0.0 (GHC: 9.0.2) (PATH: /nix/store/idqsj8zvg1kw4b3q2bcdxbqffckiwm4a-haskell-language-server-1.8.0.0/bin/haskell-language-server-wrapper)

neovim + coc

Steps to reproduce

• clone https://github.com/expipiplus1/hie-yaml-find
• Navigate to ./foo
• Run haskell-language-server
• Observe that it checks foo correctly with the foo/hie.yaml cradle
• Run vscode in foo and open Foo.hs
• Observe that it fails because it tries to read the invalid hie.yaml file in the root directory

This also happens in nvim+coc

Expected behaviour

HLS should stop at the first hie.yaml file it finds, searching upwards from the root/current directory

Actual behaviour

HLS seems to prefer hie.yaml files further up

Debug information

Can be observed in the logs like

  Root dir path: /home/e/projects/vulkan/examples
  hie.yaml path: /home/e/projects/vulkan/hie.yaml

[michaelpj]

Can you check what project root your editor is sending to HLS? It should be in the initialize request.

[michaelpj]

Just want to rule out the hypothesis that your editor is telling us the wrong root and we're just doing what we're told.

[expipiplus1]

Can you check what project root your editor is sending to HLS? It should be in the initialize request.

Here are the logs from hls and coc.nvim: https://gist.github.com/expipiplus1/66962f9518f899e206cea04632ecc2ce

Here in the HLS log, one can see that it's failed to parse the invalid hie.yaml file in the repro project root: https://gist.github.com/expipiplus1/66962f9518f899e206cea04632ecc2ce#file-hls-log-L77

Here in the Coc log I assume is what you're referencing, coc says it's sending the foo subdirectory in the initialization call: https://gist.github.com/expipiplus1/66962f9518f899e206cea04632ecc2ce#file-lsp-log-L4

[michaelpj]

Great, thanks.

@fendor I wonder if you know if the wrapper/main exe could be CD-ing wrongly? They should be using the project root from the initialize request, probably.

[expipiplus1]

FWIW, strace over the session shows three different processes reading repro/foo/hie.yaml, repro/hie.yaml and then repro/foo/hie.yaml again.

[fendor]

I am not sure from the top of my head, but it seems likely that hie-bios uses the working directory of hie.yaml to launch subprocesses.