Space leak

[pepeiborra]

A space leak was introduced in 09aa8e5.

In the benchmarks below (done in a laptop, so time measurements are not reliable), upstream7 points to said commit and upstream8 points to the preceding one:

version     name                         success   samples   startup              setup                experiment            maxResidency
v0.3.0      hover                        True      100       12.231305626000001   0.0                  0.169445642           189MB
v0.3.0      edit                         True      100       12.78367425          0.0                  30.763987565          194MB
v0.3.0      getDefinition                True      100       11.893008019000002   0.0                  0.34390903300000003   188MB
v0.3.0      hover after edit             True      100       12.628965528         0.0                  0.874594706           198MB
v0.3.0      completions after edit       True      100       11.845721274         0.0                  4.793574074           203MB
v0.3.0      code actions                 True      100       11.654060569         0.6809615240000001   0.494493726           226MB
v0.3.0      code actions after edit      True      100       12.053217982000001   0.0                  19.507116176          231MB
v0.3.0      documentSymbols after edit   True      100       11.521441841000001   0.0                  1.9631764980000002    194MB
upstream8   hover                        True      100       9.919293366          0.0                  6.1624570180000005    178MB
upstream8   edit                         True      100       9.558010323000001    0.0                  30.27085225           200MB
upstream8   getDefinition                True      100       10.069463497000001   0.0                  7.071019891000001     179MB
upstream8   hover after edit             True      100       10.523055218000001   0.0                  7.636128139           198MB
upstream8   completions after edit       True      100       10.279496557         0.0                  11.479386952          208MB
upstream8   code actions                 True      100       10.391476541000001   1.3295288010000001   6.9592471730000005    227MB
upstream8   code actions after edit      True      100       10.325661813         0.0                  25.534171453000003    229MB
upstream8   documentSymbols after edit   True      100       9.884665435          0.0                  2.010996705           182MB
upstream7   hover                        True      100       9.221848094          0.0                  9.094360360000001     577MB
upstream7   edit                         True      100       9.369224348000001    0.0                  30.425357468          597MB
upstream7   getDefinition                True      100       9.377514589          0.0                  8.94990134            577MB
upstream7   hover after edit             True      100       9.516551374          0.0                  10.044366913000001    597MB
upstream7   completions after edit       True      100       11.22539952          0.0                  14.46784101           607MB
upstream7   code actions                 True      100       10.891388644000001   1.461806607          10.342958822          575MB
upstream7   code actions after edit      True      100       9.484472901          0.0                  28.200788533          576MB
upstream7   documentSymbols after edit   True      100       9.451419864          0.0                  1.926963801           181MB

[wz1000]

Does the leak also show up in the code actions benchmark?

Missed the last column, looks like it does.