Skip to content

Clarify Binary properties of the streams #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2017
Merged

Clarify Binary properties of the streams #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77df92f
#82, remove the incorrect notes that Handle's are in binary mode.
ndmitchell Jan 22, 2017
f044a18
#82, note that all created handles are in text mode.
ndmitchell Jan 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions System/Process.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,8 @@ Note that @Handle@s provided for @std_in@, @std_out@, or @std_err@ via the
@UseHandle@ constructor will be closed by calling this function. This is not
always the desired behavior. In cases where you would like to leave the
@Handle@ open after spawning the child process, please use 'createProcess_'
instead.
instead. All created @Handle@s are initially in text mode; if you need them
to be in binary mode then use 'hSetBinaryMode'.

-}
createProcess
Expand Down Expand Up @@ -774,8 +775,7 @@ runProcess cmd args mb_cwd mb_env mb_stdin mb_stdout mb_stderr = do

{- | Runs a command using the shell, and returns 'Handle's that may
be used to communicate with the process via its @stdin@, @stdout@,
and @stderr@ respectively. The 'Handle's are initially in binary
mode; if you need them to be in text mode then use 'hSetBinaryMode'.
and @stderr@ respectively.
-}
runInteractiveCommand
:: String
Expand All @@ -797,9 +797,6 @@ runInteractiveCommand string =

> (inp,out,err,pid) <- runInteractiveProcess "..."
> forkIO (hPutStr inp str)

The 'Handle's are initially in binary mode; if you need them to be
in text mode then use 'hSetBinaryMode'.
-}
runInteractiveProcess
:: FilePath -- ^ Filename of the executable (see 'RawCommand' for details)
Expand Down