Support for records formatting

[lukasz-golebiewski]

(Optionally) turns this:

module Herp where

data Foo a = Foo { a :: Int, a2 :: String } | Bar { b :: a } 

into

module Herp where

data Foo a = Foo 
  { a :: Int
  , a2 :: String 
  } 
  | Bar
  { b :: a
  }

[jaspervdj]

Looks great! Thanks for the contribution!

[jaspervdj]

I think I would move the indent setting to the top-level, just like columns, so that other steps may possibly use this value?

[lukasz-golebiewski]

Good idea :-) Done
Thanks for the review!

[EncodePanda]

Hi @jaspervdj, is there anything else you would like us to do in this PR or is it ready to be merged?

[jaspervdj]

Hey @EncodePanda, the code looks good to me now; I just need to find some time to manually play with this, try it on a few larger codebases and then it's good to go in -- I promise I'll work on getting that done before the end of the week.

[lukasz-golebiewski]

Thanks for the review and the approve @jaspervdj !
We've noticed one "slight inconvenience" which is the removal of comments if any existed somewhere inside the data definition. We're going to spend some time on it and try to make sure they are preserved

[jaspervdj]

Okay, great that you caught that! Another option you could consider is not formatting the data definition at all if there are any comments inside.

[lukasz-golebiewski]

Good idea @jaspervdj! Looks like for now we can do what you suggested only for Haddock style comments, due to how https://hackage.haskell.org/package/haskell-src-exts-1.23.0/docs/Language-Haskell-Exts-Comments.html#v:associateHaddock works

Looks like the problem with comments being removed is more general (see #39) and probably needs to be solved in a separate PR

[EncodePanda]

We are almost there :) For now we will not format records that have comments in them but we have already a WIP that most likely will fix that (will arrive as a separate PR)

[EncodePanda]

👯‍♂