Disable formatting of data types without records #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perhaps the safest way for now is to revert to old behavior for data types -- i.e. do nothing. Attemmpt reformatting only if at least one constructor has record fields. Fixes haskell#262
|
How soon will a version with this fix be released you reckon? @jaspervdj Kinda broke styling for the whole codebase :) |
Member
|
@danbst Sorry, this fell off my radar! I'll upload a new version today. |
Member
|
@danbst Released as |
|
What a legend! Thank you @jaspervdj :) |
iphydf
added a commit
to iphydf/ci-tools
that referenced
this pull request
Mar 6, 2020
See haskell/stylish-haskell#265. Without this, stylish-haskell deletes many comments and is generally broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps the safest way for now is to revert to old behavior for data
types -- i.e. do nothing. Attemmpt reformatting only if at least one
constructor has record fields.
Fixes #262