scanl/scanr should replace invalid Char in the initial value #669
+122
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lysxia
reviewed
Oct 26, 2025
src/Data/Text.hs
Outdated
| where g a b = safe (f a b) | ||
| scanl f c0 = go | ||
| where | ||
| go (Text src o l) = runST $ do |
There was a problem hiding this comment.
Why not inline go, since it is used only once?
There was a problem hiding this comment.
The code is a modified copy of mapAccumL below: I think the idea is to allow it to inline even if only two arguments are supplied.
I doubt anyone has meaningful applications for scan* or mapAccumL. How about we inline the worker function and scrap INLINE in all four functions?
…apAccumR It's unlikely that anyone has any application for these functions, let alone a performance-critical application, so let's reduce code bloat and make implementation a tiny bit more straightforward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #668, and also makes another step towards #513.