Don't use readdir_r if deprecated #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Tbh, I'm not a big fan of having the #ifdef there (I'd rather move it to autoconf-level). But I'm not going to block this PR either if it's blocking GHC dev; I'll move it to Autoconf-phase at some later time though. PS: don't forget a changelog entry |
Member
Author
|
For the changelog entry, should I start a new section? Should I call it 2.7.2.1? |
Member
|
@erikd yes, 2.7.2.1 is fine; if it turns out to be wrong it'll be fixed up shortly before release |
GNU glibc 2.23 and later deprecate `readdir_r` in favour of plain old `readdir` which in some upcoming POSIX standard is going to required to be re-entrant. Eventually we want to drop `readder_r` all together, but want to be compatible with older unixen which may not have a re-entrant `readdir`. Solution is to make systems with *known* re-entrant `readir` use that and use `readdir_r` whereever we have it and don't *know* that `readdir` is re-entrant. Closes: haskell#70
erikd
force-pushed
the
topic/readdir-deprecated
branch
from
a7a7d5f to
2951cd0
Compare
Member
Author
|
I did look for a way to do it in autoconf, but didn't find any in a google search. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU glibc 2.23 and later deprecate
readdir_rin favour of plain oldreaddirwhich in some upcoming POSIX standard is going to required to bere-entrant.
Eventually we want to drop
readder_rall together, but want to becompatible with older unixen which may not have a re-entrant
readdir.Solution is to make systems with known re-entrant
readiruse that anduse
readdir_rwhereever we have it and don't know thatreaddirisre-entrant.
Closes: #70