Skip to content

Conversation

@toyboot4e
Copy link
Contributor

Closes #530 if merged. This PR contains:

  • The implementations in Data.Vector.Generic
  • Re-exports of them
  • And the property tests

@Shimuuar
Copy link
Contributor

PR looks good

Whether these function should included. I lean yes: we usually provide functions in 4 flavors: with/without index and monadic variants. So this brings up question which functions should be included? We have quite large API already

@toyboot4e toyboot4e changed the title Add iconcatMap, concatMapM and iconcatMapM Add iconcatMap Jun 14, 2025
@toyboot4e
Copy link
Contributor Author

I removed concatMapM and iconcatMapM from this PR. Let's add iconcatMap, as it would look natural in Hackage:

iconcatMap

Other missing functions would be monadic variants of concatMap and scan. I'd keep them in my private repository for now.

@toyboot4e toyboot4e marked this pull request as ready for review June 14, 2025 03:40
@Shimuuar Shimuuar merged commit 295e250 into haskell:master Jun 29, 2025
26 checks passed
@Shimuuar
Copy link
Contributor

Thank you! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More concatMap functions (indexed and mutable)

2 participants