Implement fusion test suite #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
This reimplements most of test as proposed by @nomeata except for slices. There're some questions on how slices should work. Test suite uses memory allocation in order to check that no intemediate vectors are constructed. It requires that GHC compiles code down to nonallocating loops and it could only reliably happen with -O2 Fixes haskell#229
Shimuuar
force-pushed
the
inspection-test
branch
3 times, most recently
from
3b0253c to
7bf8185
Compare
Let keep test for older GHC but ignore their failures
Shimuuar
force-pushed
the
inspection-test
branch
from
7bf8185 to
241c44e
Compare
Contributor
Author
|
It's done. I replace conditional compilation with ignoring result failures for older GHC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reimplements most of test as proposed by @nomeata except for slices. There're some questions on how slices should work.
Test suite uses memory allocation in order to check that no intemediate vectors are constructed. It requires that GHC compiles code down to nonallocating loops and it could only reliably happen with -O2
Fixes #229
Draft since it contains failing test for
enumFromThenTo. It's implemented in terms of list. And failing test forconcatMapwhich I haven't investigated yet.