Skip to content

How to get coc.nvim port merged cleanly? #169

@expipiplus1

Description

@expipiplus1

I've made a port to coc.nvim: https://github.com/expipiplus1/vscode-hie-server/tree/coc.nvim

I'm certainly no typescript expert, but would really like to merge the support for coc.nvim into master to avoid all the fuss of porting features back and forth. Can any typescript experts lend any advice?

I have no idea what I'm doing dog

Some things I noticed:

  • There's no window, so that prevents quite a few things mapping (things such as the docbrowser) cleanly (these have been disabled for now in my branch).
  • The registerCommand (or registerTextEditorCommand (missing)) commands have a slightly different interface, vscode passes editor and edit to them, where as the equivalents have to be fetched from the global workspace in coc.nvim
  • No difference between range and vsrange
  • Different modules are used for importing (duh)
  • strings used instead of Uris

This repository certainly isn't the place for some "compatibility layer", but perhaps if the differences are small enough then this could be done all locally.

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: enhancementAn enhancement to an already existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions