Fix unread message for starred items #88
Merged
+158
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duynguyenhoang
force-pushed
the
feature/fix_list_starred_with_unread_count
branch
5 times, most recently
from
537fd47 to
9555042
Compare
duynguyenhoang
force-pushed
the
feature/fix_list_starred_with_unread_count
branch
from
9555042 to
cae6b6c
Compare
haskellcamargo
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merged starred feature, the number of unread messages in starred list is not updated.
This PR to fix that problem
Beside that, there is an improvement on select_channel, avoid redundant loop.