Skip to content

Conversation

@frenck
Copy link
Member

@frenck frenck commented May 4, 2021

Proposed Changes

Removes the access log from NGINX from the Supervisor add-on log output.
🧹 spring cleaning!

@frenck frenck added the refactor Improvement of existing code, not introducing new features. label May 4, 2021
@frenck frenck requested a review from sinclairpaul May 4, 2021 13:06
Copy link
Member

@sinclairpaul sinclairpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thought though should we possibly enable the logging based on the log_level?, it has helped troubleshoot in the past.

@frenck
Copy link
Member Author

frenck commented May 4, 2021

Could be templated, maybe... Removed it from most other add-ons now, and don't feel like it is missing.
If we notice it is needed, it is quickly re-introduced 😄

@frenck frenck merged commit 4385cd6 into main May 4, 2021
@frenck frenck deleted the frenck-2021-1404 branch May 4, 2021 13:14
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

refactor Improvement of existing code, not introducing new features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants