Prefix function introspection #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for introspecting prefix-functions (i.e. functions which are not infix operators) as comparison operators.
How
There are a myriad of functions defined in Postgres that have a type compatible with that of a comparison operator, but which are not useful as such, or which are simply prefix-function versions of the more well know infix operators.
For instance,
has_schema_privilege(et. al.) interrogates the server's user authorization rules, andtexteqis simply(=)specialized to thetexttype.Since we don't want to clutter up the default introspected metadata with at best useless and at worst insecure functions we provide the new configuration option
introspectPrefixFunctionComparisonOperatorswhich lists out the functions that will be selected for introspection. By default this list includes various functions on builtin Postgres types and the types of PostGIS.