Skip to content

Conversation

@soupi
Copy link
Contributor

@soupi soupi commented Feb 19, 2024

What

rc14 requires we expose the equal and in operators as part of the schema response.
To do that, we have to specify them as part of the metadata.

How

  • We add a new attribute to operators - OperatorKind, which will say whether an operator is equal, in or custom, similar to ComparisonOperatorDefinition.
  • In the introspection, we map the _eq operator to the kind Equal, and other operators to Custom.
  • In the introspection, we check if a scalar type has the equal operator, and add it the in operator as well if yes.
  • We change the filtering code so that it checks the operator kind of an operator to distinguish in from the rest, instead of looking at the name.
  • We regenerate the ndc-metadata and fix the tests

We also:

  • Moved version3.* into the version3/ dir
  • Removed the old v1 and v2 config tests.

@soupi soupi added this pull request to the merge queue Feb 20, 2024
Merged via the queue into main with commit 43f032c Feb 20, 2024
@soupi soupi deleted the gil/fix-in-eq-operators branch February 20, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants