Skip to content

Conversation

@plcplc
Copy link
Contributor

@plcplc plcplc commented Mar 11, 2024

What

We change the serialization policy of the poolSettings field such that the field is always serialized, regardless of its value.

This ensures that:

  • It is possible for a user to pin the value, even the the pinned value is the default one.
  • The defaults of the field are captured at project initialization time (and optionally when introspecting anew)

@plcplc plcplc requested a review from soupi March 11, 2024 13:14
@plcplc plcplc added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit ee942fc Mar 11, 2024
@plcplc plcplc deleted the plc/make-pool-settings-explicit branch March 11, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants